Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gradient to source list items #513

Closed
sssoleileraaa opened this issue Aug 2, 2019 · 3 comments
Closed

Add gradient to source list items #513

sssoleileraaa opened this issue Aug 2, 2019 · 3 comments

Comments

@sssoleileraaa
Copy link
Contributor

sssoleileraaa commented Aug 2, 2019

Description

In order to share the same background image, there needs to be a new widget to contain the source list and conversation view (view_holder to be precise) in the MainView. Once this is added, along with #512, the same background image will show up behind the source list and conversation view.

@eloquence eloquence changed the title Add a bg widget behind source_list and view_holder Add gradient to source list items Apr 5, 2021
@eloquence
Copy link
Member

Discussed in backlog review today; we'll still need to decide if we really need a gradient on the conversation view (view_holder), or if it will be sufficient simply to add it to the source list item.

@sssoleileraaa
Copy link
Contributor Author

@ninavizz will add updated zeplin screens to this issue

@ninavizz
Copy link
Member

ninavizz commented Apr 14, 2021

Going over my own files on this topic, I now remember that I decided against including a gradient in the sourcelist highlight, when exploring options several weeks ago. Ultimately, while quite neat-o and aesthetically appealing, concern arose that it would seem too "weird" to users, and thus might stoke concern there could be a GPU or some other technical/rendering issue. Because, Qubes. As such... it is with great sadness, I close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants