Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover line widget on select #511

Closed
sssoleileraaa opened this issue Aug 2, 2019 · 5 comments
Closed

Cover line widget on select #511

sssoleileraaa opened this issue Aug 2, 2019 · 5 comments
Labels

Comments

@sssoleileraaa
Copy link
Contributor

sssoleileraaa commented Aug 2, 2019

Description

Cover the "BrakeLine" between the selected source widget and the conversation view. This will require adding a BrakeLine widget, see screenshot below:

cover-line-on-select

In Zeplin, the BreakLine shows up as 3px wide with a color of #514d6e. The BreakLine should span all the way up to the top pane and down to the bottom of the client window.

@redshiftzero
Copy link
Contributor

so right now we don't have this linewidget right? can we instead add a right-border via CSS styling for the unselected source list items?

@sssoleileraaa
Copy link
Contributor Author

we could update the SourceList widget's CSS to be

    CSS = '''
    QListView {
        border: none;
        show-decoration-selected: 0;
        border-right: 3px solid #514d6e;
    }
...

Which would look like:

border-right

However the bottom line should not merge with the right line. So this moves the problem to having to add another widget in the SourceWidget so that we can add padding between it and the outer widget.

I feel like there are a number of ways to address this. It just seemed easiest to me to have a line separator that was stand-alone, but both are perhaps equally simple. The challenge in this issue will be how to show the same background image without the right border wherever the selected source widget is. I was predicting that it would be easier to do CSS/Qt tricks if we were working with a Qt line object rather than a CSS border property, but perhaps I'm wrong.

In the meantime, we just removed borders so that it looks like a selected source is part of the conversation view.

@sssoleileraaa
Copy link
Contributor Author

I'll bring this up during the next ux meeting, but we could use this code for separating the borders:
https://gist.github.com/creviera/96795a0d40cf60c36ff88cfa92f73ebd
so that it looks like:
separate-borders
but since we decided this week to go with no borders seems fine to wait

@eloquence
Copy link
Member

Adding blocked for now - we don't agree that we want to move forward with this specific design pattern (given the implementation complexity), but it's worth keeping open as we discuss ways to polish the source list.

@zenmonkeykstop
Copy link
Contributor

Closing as a wontfix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants