-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cover line widget on select #511
Comments
so right now we don't have this linewidget right? can we instead add a right-border via CSS styling for the unselected source list items? |
we could update the SourceList widget's CSS to be
Which would look like: However the bottom line should not merge with the right line. So this moves the problem to having to add another widget in the SourceWidget so that we can add padding between it and the outer widget. I feel like there are a number of ways to address this. It just seemed easiest to me to have a line separator that was stand-alone, but both are perhaps equally simple. The challenge in this issue will be how to show the same background image without the right border wherever the selected source widget is. I was predicting that it would be easier to do CSS/Qt tricks if we were working with a Qt line object rather than a CSS border property, but perhaps I'm wrong. In the meantime, we just removed borders so that it looks like a selected source is part of the conversation view. |
I'll bring this up during the next ux meeting, but we could use this code for separating the borders: |
Adding |
Closing as a wontfix |
Description
Cover the "BrakeLine" between the selected source widget and the conversation view. This will require adding a BrakeLine widget, see screenshot below:
In Zeplin, the BreakLine shows up as 3px wide with a color of #514d6e. The BreakLine should span all the way up to the top pane and down to the bottom of the client window.
The text was updated successfully, but these errors were encountered: