Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pull request templates for common tasks #380

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Add pull request templates for common tasks #380

merged 1 commit into from
Sep 27, 2022

Conversation

gonzalo-bulnes
Copy link
Contributor

@gonzalo-bulnes gonzalo-bulnes commented Sep 22, 2022 •
edited
Loading

This is primarily aimed at preventing us from missing any dependency review in the future.

  1. Adds an item to remind that diff reviews must be performed when adding packages
  2. Adds a template for change log updates, which are relatively frequent
  3. Moves the default template, and rewords it slightly to match the other

Prompted by: #379

@gonzalo-bulnes gonzalo-bulnes added automation 🏖️ summer cleaning refactors such as removing dead code labels Sep 22, 2022
sssoleileraaa
sssoleileraaa suggested changes Sep 26, 2022
View reviewed changes
.github/PULL_REQUEST_TEMPLATE/package_addition.md
@@ -0,0 +1,22 @@
---
name: Package addition
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could also be for a package upgrade. My one request would be that you update wording to include upgrades as well as new packages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I'll add it.

.github/PULL_REQUEST_TEMPLATE/changelog_update.md Show resolved Hide resolved
@gonzalo-bulnes gonzalo-bulnes changed the title Add pull request templates for comon tasks Add pull request templates for common tasks Sep 27, 2022
@gonzalo-bulnes
Add pull request templates for common tasks
a7777d4 
This is primarily aimed at preventing us from missing
any dependency review in the future.
@gonzalo-bulnes gonzalo-bulnes force-pushed the add-diff-review-to-pull-request-template branch from 9fabb6c to a7777d4 Compare September 27, 2022 01:39
@gonzalo-bulnes
Copy link
Contributor Author

Ready to re-review @creviera !

sssoleileraaa
sssoleileraaa approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sssoleileraaa sssoleileraaa merged commit fdd25c4 into main Sep 27, 2022
@sssoleileraaa sssoleileraaa deleted the add-diff-review-to-pull-request-template branch September 27, 2022 02:41
@gonzalo-bulnes gonzalo-bulnes mentioned this pull request Oct 5, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sssoleileraaa sssoleileraaa sssoleileraaa approved these changes

@legoktm legoktm Awaiting requested review from legoktm

Assignees
No one assigned
Labels
automation 🏖️ summer cleaning refactors such as removing dead code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gonzalo-bulnes @sssoleileraaa