Skip to content

Commit

Permalink
Add pull request templates for comon tasks
Browse files Browse the repository at this point in the history
This is primarily aimed at preventing us from missing
any dependency review in the future.
  • Loading branch information
gonzalo-bulnes committed Sep 22, 2022
1 parent abea688 commit 9fabb6c
Show file tree
Hide file tree
Showing 4 changed files with 48 additions and 5 deletions.
9 changes: 9 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE/changelog_update.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
name: Change log update
about: Prepare the release of a Debian package.

---

## Description

_Which package are you releasing? Please link to to **release tracking issue**._
17 changes: 17 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE/default.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
---
name: Default
about: For all the cases that don't have a specific template.

---

## Description

_What is the PR doing, and why?_

## Test plan

- Automated tests ([Circle CI][ci]):
- [ ] All Bullseye jobs are passing
- Bookworm failures are not ignored:
- [ ] This PR does not introduce any new Bookworm failures
- [ ] An issue is open for all new Bookworm failures
22 changes: 22 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE/package_addition.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
---
name: Package addition
about: Add a dependency for one of our Debian packages.

---

## Description

_Which packages are you adding, and why?_

## Test plan

- Automated tests ([Circle CI][ci]):
- [ ] All Bullseye jobs are passing
- [ ] Bookworm failures are not ignored:
- This PR does not introduce any new Bookworm failures
- An issue is open for all new Bookworm failures
- Security:
- [ ] A [diff review][review-docs] was performed for all build dependencies

[ci]: https://app.circleci.com/pipelines/github/freedomofpress/securedrop-debian-packaging
[review-docs]: https://github.com/freedomofpress/securedrop/wiki/Dependency-specification-and-update-policies
5 changes: 0 additions & 5 deletions PULL_REQUEST_TEMPLATE.md

This file was deleted.

0 comments on commit 9fabb6c

Please sign in to comment.