Skip to content
This repository has been archived by the owner on Sep 25, 2019. It is now read-only.

fix(challenges): removed a test in basic javascript challenge #76

Conversation

gforce2k5
Copy link
Contributor

removed a test looking for timesFive call and it is not clear from the instrucitons to do so

ISSUES CLOSED: #73

Pre-Submission Checklist

  • Your pull request targets the staging branch of freeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

  • Tested changes locally.
  • Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #73

Description

Copy link
Member

@Nirajn2311 Nirajn2311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

removed a test looking for timesFive call and it is not clear from the instrucitons to do so

ISSUES CLOSED: freeCodeCamp#73
@raisedadead raisedadead force-pushed the fix/instructions-for-javascript-challenge branch from d186195 to 1fe1f0c Compare June 29, 2018 18:41
@raisedadead raisedadead merged commit ff26697 into freeCodeCamp:dev Jun 29, 2018
raisedadead pushed a commit that referenced this pull request Jun 30, 2018
## [3.0.1](v3.0.0...v3.0.1) (2018-06-30)

### Bug Fixes

* **challenges:** change comment to make it clearer ([#72](#72)) ([46fcf43](46fcf43))
* **challenges:** fix a test case in an Applied Accessibility ([4c0d587](4c0d587))
* **challenges:** remove unnecessary test cases ([17af3dd](17af3dd))
* **challenges:** removed a test in basic javascript challenge ([#76](#76)) ([ff26697](ff26697)), closes [#73](#73)
* **challenges:** removed comment in the seed ([6a8a9db](6a8a9db))
* **challenges:** removed redundant text from challenge ([c37a1e8](c37a1e8)), closes [#36](#36)
@raisedadead
Copy link
Member

🎉 This PR is included in version 3.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

raisedadead pushed a commit that referenced this pull request Jun 30, 2018
## [3.0.1](v3.0.0...v3.0.1) (2018-06-30)

### Bug Fixes

* **challenges:** change comment to make it clearer ([#72](#72)) ([46fcf43](46fcf43))
* **challenges:** fix a test case in an Applied Accessibility ([4c0d587](4c0d587))
* **challenges:** remove unnecessary test cases ([17af3dd](17af3dd))
* **challenges:** removed a test in basic javascript challenge ([#76](#76)) ([ff26697](ff26697)), closes [#73](#73)
* **challenges:** removed comment in the seed ([6a8a9db](6a8a9db))
* **challenges:** removed redundant text from challenge ([c37a1e8](c37a1e8)), closes [#36](#36)
@gforce2k5 gforce2k5 deleted the fix/instructions-for-javascript-challenge branch June 30, 2018 06:12
anku255 pushed a commit to anku255/curriculum that referenced this pull request Jun 30, 2018
…deCamp#76)

removed a test looking for timesFive call and it is not clear from the instrucitons to do so

ISSUES CLOSED: freeCodeCamp#73
anku255 pushed a commit to anku255/curriculum that referenced this pull request Jun 30, 2018
## [3.0.1](freeCodeCamp/curriculum@v3.0.0...v3.0.1) (2018-06-30)

### Bug Fixes

* **challenges:** change comment to make it clearer ([freeCodeCamp#72](freeCodeCamp#72)) ([46fcf43](freeCodeCamp@46fcf43))
* **challenges:** fix a test case in an Applied Accessibility ([4c0d587](freeCodeCamp@4c0d587))
* **challenges:** remove unnecessary test cases ([17af3dd](freeCodeCamp@17af3dd))
* **challenges:** removed a test in basic javascript challenge ([freeCodeCamp#76](freeCodeCamp#76)) ([ff26697](freeCodeCamp@ff26697)), closes [freeCodeCamp#73](freeCodeCamp#73)
* **challenges:** removed comment in the seed ([6a8a9db](freeCodeCamp@6a8a9db))
* **challenges:** removed redundant text from challenge ([c37a1e8](freeCodeCamp@c37a1e8)), closes [freeCodeCamp#36](freeCodeCamp#36)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incomplete Instructions for Basic JavaScript: Return a Value from a Function with Return
3 participants