This repository has been archived by the owner on Sep 25, 2019. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 125
fix(challenges): removed a test in basic javascript challenge #76
Merged
raisedadead
merged 1 commit into
freeCodeCamp:dev
from
gforce2k5:fix/instructions-for-javascript-challenge
Jun 29, 2018
Merged
fix(challenges): removed a test in basic javascript challenge #76
raisedadead
merged 1 commit into
freeCodeCamp:dev
from
gforce2k5:fix/instructions-for-javascript-challenge
Jun 29, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nirajn2311
approved these changes
Jun 29, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
raisedadead
force-pushed
the
dev
branch
2 times, most recently
from
June 29, 2018 18:07
1e9ed03
to
de6a375
Compare
raisedadead
force-pushed
the
fix/instructions-for-javascript-challenge
branch
from
June 29, 2018 18:34
31b1529
to
d186195
Compare
removed a test looking for timesFive call and it is not clear from the instrucitons to do so ISSUES CLOSED: freeCodeCamp#73
raisedadead
force-pushed
the
fix/instructions-for-javascript-challenge
branch
from
June 29, 2018 18:41
d186195
to
1fe1f0c
Compare
raisedadead
pushed a commit
that referenced
this pull request
Jun 30, 2018
## [3.0.1](v3.0.0...v3.0.1) (2018-06-30) ### Bug Fixes * **challenges:** change comment to make it clearer ([#72](#72)) ([46fcf43](46fcf43)) * **challenges:** fix a test case in an Applied Accessibility ([4c0d587](4c0d587)) * **challenges:** remove unnecessary test cases ([17af3dd](17af3dd)) * **challenges:** removed a test in basic javascript challenge ([#76](#76)) ([ff26697](ff26697)), closes [#73](#73) * **challenges:** removed comment in the seed ([6a8a9db](6a8a9db)) * **challenges:** removed redundant text from challenge ([c37a1e8](c37a1e8)), closes [#36](#36)
🎉 This PR is included in version 3.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
raisedadead
pushed a commit
that referenced
this pull request
Jun 30, 2018
## [3.0.1](v3.0.0...v3.0.1) (2018-06-30) ### Bug Fixes * **challenges:** change comment to make it clearer ([#72](#72)) ([46fcf43](46fcf43)) * **challenges:** fix a test case in an Applied Accessibility ([4c0d587](4c0d587)) * **challenges:** remove unnecessary test cases ([17af3dd](17af3dd)) * **challenges:** removed a test in basic javascript challenge ([#76](#76)) ([ff26697](ff26697)), closes [#73](#73) * **challenges:** removed comment in the seed ([6a8a9db](6a8a9db)) * **challenges:** removed redundant text from challenge ([c37a1e8](c37a1e8)), closes [#36](#36)
anku255
pushed a commit
to anku255/curriculum
that referenced
this pull request
Jun 30, 2018
…deCamp#76) removed a test looking for timesFive call and it is not clear from the instrucitons to do so ISSUES CLOSED: freeCodeCamp#73
anku255
pushed a commit
to anku255/curriculum
that referenced
this pull request
Jun 30, 2018
## [3.0.1](freeCodeCamp/curriculum@v3.0.0...v3.0.1) (2018-06-30) ### Bug Fixes * **challenges:** change comment to make it clearer ([freeCodeCamp#72](freeCodeCamp#72)) ([46fcf43](freeCodeCamp@46fcf43)) * **challenges:** fix a test case in an Applied Accessibility ([4c0d587](freeCodeCamp@4c0d587)) * **challenges:** remove unnecessary test cases ([17af3dd](freeCodeCamp@17af3dd)) * **challenges:** removed a test in basic javascript challenge ([freeCodeCamp#76](freeCodeCamp#76)) ([ff26697](freeCodeCamp@ff26697)), closes [freeCodeCamp#73](freeCodeCamp#73) * **challenges:** removed comment in the seed ([6a8a9db](freeCodeCamp@6a8a9db)) * **challenges:** removed redundant text from challenge ([c37a1e8](freeCodeCamp@c37a1e8)), closes [freeCodeCamp#36](freeCodeCamp#36)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed a test looking for timesFive call and it is not clear from the instrucitons to do so
ISSUES CLOSED: #73
Pre-Submission Checklist
staging
branch of freeCodeCamp.fix/
,feature/
, ortranslate/
(e.g.fix/signin-issue
)npm test
. Usegit commit --amend
to amend any fixes.Type of Change
Checklist:
Closes #73
Description