Skip to content
This repository has been archived by the owner on Sep 25, 2019. It is now read-only.

Incomplete Instructions for Basic JavaScript: Return a Value from a Function with Return #73

Closed
Bouncey opened this issue Jun 28, 2018 · 2 comments · Fixed by #76 or #88
Closed

Incomplete Instructions for Basic JavaScript: Return a Value from a Function with Return #73

Bouncey opened this issue Jun 28, 2018 · 2 comments · Fixed by #76 or #88

Comments

@Bouncey
Copy link
Member

Bouncey commented Jun 28, 2018

@Nirajn2311 commented on Thu Jun 28 2018

Describe your problem and - if possible - how to reproduce it

The instructions instruct us to create a function timesFive but it doesn't tell us to call the function after creating it. So when anyone does the challenge they will get an error.
I think that the instructions should be modified to include all steps.
@Bouncey @raisedadead can I make a PR on this in the curriculum repo?

Add a Link to the page with the problem

https://learn.freecodecamp.org/javascript-algorithms-and-data-structures/basic-javascript/return-a-value-from-a-function-with-return

Tell us about your browser and operating system

  • Browser Name: Google Chrome
  • Browser Version: 67.0.3396.99
  • Operating System: Windows 10 Home 1803

If possible, add a screenshot here
@Bouncey Bouncey mentioned this issue Jun 28, 2018
Closed
@Bouncey
Copy link
Member Author

Bouncey commented Jun 28, 2018

I would be in favour of just removing the test for function timesFive should be called with a number

@Nirajn2311 go ahead and make the PR if you wish to

gforce2k5 added a commit to gforce2k5/curriculum that referenced this issue Jun 29, 2018
@gforce2k5
fix(challenges): removed a test in basic javascript challenge
31b1529 
removed a test looking for timesFive call and it is not clear from the instrucitons to do so

ISSUES CLOSED: freeCodeCamp#73
@gforce2k5 gforce2k5 mentioned this issue Jun 29, 2018
Merged
10 tasks
raisedadead pushed a commit to gforce2k5/curriculum that referenced this issue Jun 29, 2018
@gforce2k5 @raisedadead
fix(challenges): removed a test in basic javascript challenge
d186195 
removed a test looking for timesFive call and it is not clear from the instrucitons to do so

ISSUES CLOSED: freeCodeCamp#73
raisedadead pushed a commit to gforce2k5/curriculum that referenced this issue Jun 29, 2018
@gforce2k5 @raisedadead
fix(challenges): removed a test in basic javascript challenge
1fe1f0c 
removed a test looking for timesFive call and it is not clear from the instrucitons to do so

ISSUES CLOSED: freeCodeCamp#73
raisedadead pushed a commit that referenced this issue Jun 29, 2018
@gforce2k5 @raisedadead
fix(challenges): removed a test in basic javascript challenge (#76)
ff26697 
removed a test looking for timesFive call and it is not clear from the instrucitons to do so

ISSUES CLOSED: #73
raisedadead pushed a commit that referenced this issue Jun 30, 2018
@camperbot
chore(release): 3.0.1 [skip ci]
f41d021 
## [3.0.1](v3.0.0...v3.0.1) (2018-06-30)

### Bug Fixes

* **challenges:** change comment to make it clearer ([#72](#72)) ([46fcf43](46fcf43))
* **challenges:** fix a test case in an Applied Accessibility ([4c0d587](4c0d587))
* **challenges:** remove unnecessary test cases ([17af3dd](17af3dd))
* **challenges:** removed a test in basic javascript challenge ([#76](#76)) ([ff26697](ff26697)), closes [#73](#73)
* **challenges:** removed comment in the seed ([6a8a9db](6a8a9db))
* **challenges:** removed redundant text from challenge ([c37a1e8](c37a1e8)), closes [#36](#36)
@raisedadead
Copy link
Member

🎉 This issue has been resolved in version 3.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@raisedadead raisedadead mentioned this issue Jun 30, 2018
Merged
raisedadead pushed a commit that referenced this issue Jun 30, 2018
@camperbot @raisedadead
chore(release): 3.0.1 [skip ci]
7667bfa 
## [3.0.1](v3.0.0...v3.0.1) (2018-06-30)

### Bug Fixes

* **challenges:** change comment to make it clearer ([#72](#72)) ([46fcf43](46fcf43))
* **challenges:** fix a test case in an Applied Accessibility ([4c0d587](4c0d587))
* **challenges:** remove unnecessary test cases ([17af3dd](17af3dd))
* **challenges:** removed a test in basic javascript challenge ([#76](#76)) ([ff26697](ff26697)), closes [#73](#73)
* **challenges:** removed comment in the seed ([6a8a9db](6a8a9db))
* **challenges:** removed redundant text from challenge ([c37a1e8](c37a1e8)), closes [#36](#36)
anku255 pushed a commit to anku255/curriculum that referenced this issue Jun 30, 2018
@gforce2k5 @anku255
fix(challenges): removed a test in basic javascript challenge (freeCo…
74b6704 
…deCamp#76)

removed a test looking for timesFive call and it is not clear from the instrucitons to do so

ISSUES CLOSED: freeCodeCamp#73
anku255 pushed a commit to anku255/curriculum that referenced this issue Jun 30, 2018
@camperbot @anku255
chore(release): 3.0.1 [skip ci]
2810402 
## [3.0.1](freeCodeCamp/curriculum@v3.0.0...v3.0.1) (2018-06-30)

### Bug Fixes

* **challenges:** change comment to make it clearer ([freeCodeCamp#72](freeCodeCamp#72)) ([46fcf43](freeCodeCamp@46fcf43))
* **challenges:** fix a test case in an Applied Accessibility ([4c0d587](freeCodeCamp@4c0d587))
* **challenges:** remove unnecessary test cases ([17af3dd](freeCodeCamp@17af3dd))
* **challenges:** removed a test in basic javascript challenge ([freeCodeCamp#76](freeCodeCamp#76)) ([ff26697](freeCodeCamp@ff26697)), closes [freeCodeCamp#73](freeCodeCamp#73)
* **challenges:** removed comment in the seed ([6a8a9db](freeCodeCamp@6a8a9db))
* **challenges:** removed redundant text from challenge ([c37a1e8](freeCodeCamp@c37a1e8)), closes [freeCodeCamp#36](freeCodeCamp#36)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@raisedadead @Bouncey