CLAP 1.2.0 #371
Merged
CLAP 1.2.0 #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing called multiple times
Adjust active and processing state documentation
Correct referenced function name in comment
Explaning how the wildcard voice lookup works
Expanded discussion of -1 wildcard note address mechanism
ritschwumm
reviewed
Dec 20, 2023
ritschwumm
reviewed
Dec 20, 2023
ritschwumm
reviewed
Dec 20, 2023
ritschwumm
reviewed
Dec 20, 2023
ritschwumm
reviewed
Dec 20, 2023
Bremmers
reviewed
Dec 20, 2023
Expand some note and note expression doc
1. fix a small grammar mistake 2. crystal clear on what semitone means
Expand note expression tuning description just a bit
baconpaul
approved these changes
Jan 15, 2024
To be consistent with all the other extensions
Bremmers
reviewed
Jan 17, 2024
| // VST2: print the id as a signed 32-bits integer | ||
| // eg: "-4382976" | ||
| // | ||
| // VST3: print the id as a standard UUID |
There was a problem hiding this comment.
On the other hand any uuid helper can deal with both lower case and upper case right?
It just has to be a valid uuid.
There was a problem hiding this comment.
Yeah, requiring lower case can even cause problems if some people support uppercase anyway, and some don't.
Then perhaps add "Both lower and upper case are allowed.", so people know they have to be prepared for both?
It can be an issue if you compare strings.
defiantnerd
approved these changes
Jan 17, 2024
include/clap/ext/draft/ambisonic.h
Outdated
There was a problem hiding this comment.
didn't we need this for the configurable audio ports extension?
There was a problem hiding this comment.
static CLAP_CONSTEXPR const char CLAP_EXT_CONFIGURABLE_AUDIO_PORTS[] = "clap.configurable-audio-ports.draft1";
refers still to "draft"
Trinitou
reviewed
Jan 18, 2024
Trinitou
reviewed
Jan 18, 2024
Add CLAP_CONSTEXPR to voice-info and preset-load id declarations
Rename clap_timestamp_t to clap_timestamp and move to separate header
Trinitou
suggested changes
Jan 18, 2024
Document null terminated string members of clap_universal_plugin_id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.