Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand note expression tuning description just a bit #382

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Expand note expression tuning description just a bit #382

merged 1 commit into from
Jan 15, 2024

Conversation

baconpaul
Copy link
Collaborator

  1. fix a small grammar mistake
  2. crystal clear on what semitone means

@baconpaul
Expand note expression tuning description just a bit
b237186 
1. fix a small grammar mistake
2. crystal clear on what semitone means
@baconpaul
Copy link
Collaborator Author

This is already in the changelog; just a tweak based on a review that came in after you merged @abique

@baconpaul baconpaul mentioned this pull request Jan 15, 2024
Merged
abique
abique requested changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@abique abique left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think after ; it shouldn't be capitalized but then the sentence should terminate with . maybe because it already used punctuation?

@abique
Copy link
Contributor

abique commented Jan 15, 2024

I take care of it.

@abique abique merged commit 5652063 into free-audio:next Jan 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abique abique abique requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baconpaul @abique