fix: better gls for purchases with tax witholding (backport #42743) #44048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* fix: better gls for purchases with tax witholding * test: test case for purchase invoice gl entries with tax witholding * fix: use flag `_skip_merge` instead of skipping merge based on against account * test: fix test `test_single_threshold_tds` for newer implementation (cherry picked from commit e3cd653)
mergify
bot
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scenario
Issue
Accounting for payable to supplier was done for Rs 49500 + GST
This could raise concerns by the supplier because the invoice is of Rs 50000 + GST
Fix
General Ledger Report After Fix
General Ledger Print with Remarks (when grouped by voucher - without consolidation)
Frappe Internal Reference: https://support.frappe.io/helpdesk/tickets/20049
Possible extension of this fix needed for Sales Invoice and Payment Entry.
This is an automatic backport of pull request #42743 done by Mergify.