fix: better gls for purchases with tax witholding #42743
Conversation
github-actions
bot
added
accounts
needs-tests
|
Same issue in Sales Invoice and Payment Entry. |
|
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
|
@vorasmit @deepeshgarg007 @ruthra-kumar Any updates regarding this PR? We have same issue in Sales Invoice and Payment Entry. |
|
This solution is only for cases where a company is responsible for deducting TDS/TCS in Purchase/Sales Invoice. This will not work where TDS is deducted from the companies Invoice by customer. |
@vorasmit Then what is the solution for this? |
|
In addition to changes in this PR for Payment Entry, following additional changes may be required: In Payment Entry => In references table, we'll have to allow deductions against each invoice somehow. This is complex as it may need to be handled at multiple places, including Advances table in Sales Invoice or Payment Reconciliation. |
|
When this will be merged into Version-15? |
|
Similar implementation was not required in Sales Invoice and Payment Entry. For Sales Invoice, if TCS is charged, it goes as a part of Sales Invoice to customer and he can match with the total amount of Invoice. For Payment Entry, print format is comprehensive, and gives breakup of TDS. Hence existing implementation for Purchase Invoice looks sufficient. |
vorasmit
force-pushed
the
tds-gl
branch
2 times, most recently
from
0032cda
to
ebf74c3
Compare
vorasmit
added
squash
* fix: better gls for purchases with tax witholding * test: test case for purchase invoice gl entries with tax witholding * fix: use flag `_skip_merge` instead of skipping merge based on against account * test: fix test `test_single_threshold_tds` for newer implementation (cherry picked from commit e3cd653)
…-42743 fix: better gls for purchases with tax witholding (backport #42743)
# [15.42.0](v15.41.2...v15.42.0) (2024-11-13) ### Bug Fixes * add default height to POS item card selector (backport [#44071](#44071)) ([#44075](#44075)) ([65ec7c5](65ec7c5)) * add field conversion_factor when include_uom is settled ([#43701](#43701)) ([f387a8f](f387a8f)) * better gls for purchases with tax witholding ([#42743](#42743)) ([705a26a](705a26a)) * bind this object explicitly on callback event function ([3423d3c](3423d3c)) * calculate percentage received and delivered considering over-receipt and over-delivery (backport [#43870](#43870)) ([#44030](#44030)) ([5958d0c](5958d0c)) * Cannot read properties of undefined (reading 'work_order_closed') (backport [#44117](#44117)) ([#44122](#44122)) ([c1983a4](c1983a4)) * consider service item cost in the RM cost of the BOM (backport [#43962](#43962)) ([#44111](#44111)) ([6e83fec](6e83fec)) * Drop Shipping address based on customer shopping address ([8af005c](8af005c)) * duplicate items and outdated item price in POS (backport [#42978](#42978)) ([#44038](#44038)) ([4cde77d](4cde77d)) * exception on register reports when filtered on cost center ([be07421](be07421)) * improved the conditions for determining voucher subtypes ([58ca4a2](58ca4a2)) * incorrect produced qty in Production Plan Summary (backport [#44112](#44112)) ([#44113](#44113)) ([bce7acf](bce7acf)) * item mapping from modal to batch form ([#44090](#44090)) ([9ac54f6](9ac54f6)) * item not set in the batch quick entry form (backport [#44028](#44028)) ([#44031](#44031)) ([6dcd015](6dcd015)) * Negative stock validation against inventory dimension (backport [#43834](#43834)) ([#43846](#43846)) ([b314f38](b314f38)) * NoneType while updating ordered_qty in SO for removed items ([978a007](978a007)) * not able to cancel DN (backport [#44108](#44108)) ([#44109](#44109)) ([290bdde](290bdde)) * not able to reconcile expired batches ([#44012](#44012)) ([4ba07a4](4ba07a4)) * patch ([107d53b](107d53b)) * populate payment schedule from payment terms (backport [#44082](#44082)) ([#44083](#44083)) ([363f151](363f151)) * purchase receipt creation from SCR ([#44095](#44095)) ([e3d7468](e3d7468)) * slow reposting due to SABB update ([3e29ae8](3e29ae8)) * sort by ascending to get the first period closing voucher (backport [#44029](#44029)) ([#44035](#44035)) ([56f25ae](56f25ae)) * task path (backport [#44073](#44073)) ([#44078](#44078)) ([34b5639](34b5639)) * tyeerror while saving pick list ([7d09832](7d09832)) * update payment amount for partial pos return ([61559be](61559be)) * update per_billed value in Purchase Receipt while creating Debit Note ([#43977](#43977)) ([a833dd6](a833dd6)) * when company is created with other company template Chart of Account the Create Taxe Template failed ([#42755](#42755)) ([e6894b9](e6894b9)) ### Features * Add item group filtering for search results ([2754793](2754793)) * add template taxe for charts of account France - Plan Comptable General avec code ([#42757](#42757)) ([865786e](865786e))
Scenario
Issue
Accounting for payable to supplier was done for Rs 49500 + GST
This could raise concerns by the supplier because the invoice is of Rs 50000 + GST
Fix
General Ledger Report After Fix
General Ledger Print with Remarks (when grouped by voucher - without consolidation)
Frappe Internal Reference: https://support.frappe.io/helpdesk/tickets/20049
Possible extension of this fix needed for Sales Invoice and Payment Entry.