merge upstream #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bugfix: zypper ZYPPER_EXIT_NO_REPOS exit code
Bugfix: zypper ZYPPER_EXIT_NO_REPOS exit code
Clean up install of package from shell test
Fix 3 bugs in subdict matching
fixing an issue where sentry logger would fail to get tags from grain…
…tice Use py3-preferred plistlib API to load service plists.
Since "pchanges" was never supported in the state compiler, and "changes" is what these reqs always used, replacing "pchanges" with "changes" will allow those requisites to work in test mode.
This allows for a state return dict to be repacked so that the top level keys are the IDs, making it much easier to analyze and craft asserts against the results.
this requisite passes a __prerequired__ kwarg so these need to support **kwargs for that reason. This also changes the comment for salt.function in test mode because it's inaccurate and doesn't make sense.
[develop] Adding some tests for the vault execution module.
[fluorine] Merge forward from 2018.3 to fluorine
[develop] Merge forward from fluorine to develop
Conflicts: - salt/cloud/clouds/saltify.py - salt/modules/network.py - tests/unit/modules/test_network.py
Master stats latency
Add parameter named grains_blacklist
values need to be bytes when writing back to ldap
saltnado: teach runner about full_return
[develop] Merge forward from fluorine to develop
Don't return False when target exists (file.rename)
Change versionadded for loadable matchers to Neon
Replace pchanges with changes to make onchanges/prereq work in test mode
Document behavior change in file.rename state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
Previous Behavior
Remove this section if not relevant
New Behavior
Remove this section if not relevant
Tests written?
Yes/No
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.