Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: zypper ZYPPER_EXIT_NO_REPOS exit code #49805

Merged
merged 3 commits into from
Sep 28, 2018

Conversation

isbm
Copy link
Contributor

@isbm isbm commented Sep 27, 2018

What does this PR do?

pkg.installed reports failed if the following conditions are met:

  1. No repos configured
  2. Package already installed anyway

What issues does this PR fix or reference?

pkg.installed does not report failed if the following conditions above are met.

Caveats

Zypper (all versions) still contains a bug (which is already fixed as of today) — https://bugzilla.suse.com/show_bug.cgi?id=1109893 — where new package installation fails with the same exit code. That said, pkg.installed will work, but pkg.install from execution command will not fail, if you did not upgrade zypper.

Tests written?

No

Should just pass existing.

@ghost ghost self-requested a review September 27, 2018 15:01
@rallytime rallytime merged commit 10e8b01 into saltstack:develop Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants