feat(cast): add flag equivalents of parseUnits, formatUnits
#9165
Conversation
kien6034
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
There was a problem hiding this comment.
thank you! could you please add tests for these new options, you can see examples of usint casttest! macro here https://github.com/foundry-rs/foundry/blob/master/crates/cast/tests/cli/main.rs
Also mind that "fu" alias is already used for from-utf8
cast fu --help
Convert UTF8 text to hex
Usage: cast from-utf8 [TEXT]
hence tests are failing (see https://github.com/foundry-rs/foundry/blob/master/CONTRIBUTING.md#resolving-an-issue on how to run them locally)
|
thank you for reviewing @grandizzy. im not at home currently, will update tonight |
|
Hello @grandizzy , i updated the allias for formatUnits, added the tests and checked lint and testing on local |
tests pass locally, the failing tests are flaky i assume
|
|
@grandizzy tks. Updated |
|
oops, sorry, my suggestion to rename test broke it :) will revert |
|
@grandizzy no, i was my mistake, i change the function name incorrectly. Sry about that |
There was a problem hiding this comment.
lgtm, thank you! @zerosnacks @yash-atreya mind review it too?
There was a problem hiding this comment.
Thanks @kien6034 for your PR, proposed feature LGTM
Tested it with a wide range of numbers and it works well
Noticed that it does not specifically handle hexadecimal numbers but that is OK as it is out of the scope of this ticket
…y-rs#9165) * feat: base func for parseunints and formatuints * test: update doc and tests * fix: function alias * test: cast test * refacctor: helper fucnction * Update crates/cast/tests/cli/main.rs * revert: format uints function cattest func name --------- Co-authored-by: grandizzy <[email protected]>
Motivation
Closes #9030
Solution
Add two new functions to support arbitrary decimal places in unit conversions:
parse_units: Convert human-readable numbers to their smallest unit representationformat_units: Convert numbers from smallest unit back to human-readable formatAdded test cases for common scenarios: