Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cast): add flag equivalents of parseUnits, formatUnits #9030

Closed
0xdapper opened this issue Oct 4, 2024 · 3 comments · Fixed by #9165
Closed

feat(cast): add flag equivalents of parseUnits, formatUnits #9030

0xdapper opened this issue Oct 4, 2024 · 3 comments · Fixed by #9165
Assignees
Labels
C-cast Command: cast first issue A good way to start contributing T-feature Type: feature

Comments

@0xdapper
Copy link
Contributor

0xdapper commented Oct 4, 2024

Component

Cast

Describe the feature you would like

cast --from-wei <wei> is equivalent to parseEther
cast --to-wei <ether> is equivalent to formatEther

However, cast --to-unit is not equivalents of the more generic parseUnits. It only supports parsing to wei, gwei, ether, not to arbitrary decimals.

I couldn't find a cast --from-unit altogether.

This feature request is to add functionality to parse and format numbers to arbitrary decimals.

Additional context

No response

@0xdapper 0xdapper added T-feature Type: feature T-needs-triage Type: this issue needs to be labelled labels Oct 4, 2024
@github-project-automation github-project-automation bot moved this to Todo in Foundry Oct 4, 2024
@zerosnacks zerosnacks added C-cast Command: cast and removed T-needs-triage Type: this issue needs to be labelled labels Oct 4, 2024
@zerosnacks zerosnacks changed the title feat(cast): equivalents of parseUnits, formatUnits feat(cast): add flag equivalents of parseUnits, formatUnits Oct 4, 2024
@DaniPopes DaniPopes added the first issue A good way to start contributing label Oct 16, 2024
@kien6034
Copy link
Contributor

hello, i would like to work on this

@zerosnacks
Copy link
Member

@kien6034 thanks! assigned

@kien6034
Copy link
Contributor

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cast Command: cast first issue A good way to start contributing T-feature Type: feature
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants