fix: running script with --broadcast for a transaction sequence can error out due to nonce desync from rpc latency
#9096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pogobounce
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
klkvr
requested changes
Oct 12, 2024
There was a problem hiding this comment.
provider reporting nonce which is behind might mean several things — there might've been a reorg or node might just still be updating state even though block with previous nonce was already included but latest state is not yet updated
in both cases we'd want to wait until we are sure that previous transaction is available in state because otherwise estimate_gas below might fail
let's add a loop here which would do several attempts at fetching and comparing nonce with some delay, and if after eg 5 iterations we still have a mismatch we'd always fail
|
implemented a loop, seems to do the job, as my test broadcasts all work well should I change implementation in any way? |
2 tasks
zerosnacks
changed the title
--broadcast for a transaction sequence can error out due to nonce desync from rpc latency
klkvr
approved these changes
Oct 14, 2024
rplusq
pushed a commit
to rplusq/foundry
that referenced
this pull request
Nov 29, 2024
… error out due to nonce desync from rpc latency (foundry-rs#9096) * fix for issue foundry-rs#9095 * changed 'if' statement into 'match' * fmt fix * repeat ask for provider nonce on desync * loop break and tokio::time use instead of std::thread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
On some chains with fast block times and/or relatively high latency providers, running a deployment script with
--broadcastthat sends a sequence of transactions can lead to the script failing, as the RPC will report an older nonce for the EOA.Solution
If the RPC is out of sync with the current nonce, there's two options:
If it returns a nonce that is ahead, it likely means that the EOA executed some other transaction meanwhile, so the script should stop.
However, if the nonce is ahead, the culprit is likely a slow RPC. In that case, it makes sense to continue to proceed with the transaction sequence.
Treating these two cases separately means the sequence of transactions won't get stopped out.