fix(anvil): update blockhash in db #2598
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
the test introduced in #2524 makes use of
roll
cheatcode, first byvm.roll(block.number - numUpdates)
;then simulates mining by
which does
blockhash(block.number - 1)
this highlighted a problem with block hashes in anvil that were not updated internally in the
Db
this meant that if a tx requires a hash for a block that was already mined by anvil but is now missing in the DB's internal storage it will try to query it from the endpoint but if there's no new block it will return the 0 hash
blockhash(block.number - 1)
Solution
manually insert the new blockhash in the db after mining a new block