Add --skip-simulation and --gas-estimate-multiplier cli options to forge script command
#2524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckoopmann
force-pushed
the
disable-on-chain-simulation
branch
from
3baee7d to
6b44708
Compare
ckoopmann
force-pushed
the
disable-on-chain-simulation
branch
from
6cea2cc to
f1fe4e3
Compare
ckoopmann
force-pushed
the
disable-on-chain-simulation
branch
from
f1fe4e3 to
502a2be
Compare
ckoopmann
changed the title
--skip-simulation and --gas-estimate-multiplier cli options to forge script command
|
@onbjerg: Any feedback / review on this would be greatly appreciated 🙏 |
onbjerg
approved these changes
Aug 3, 2022
2 tasks
2 tasks
mattsse
approved these changes
Aug 3, 2022
This was referenced Aug 8, 2022
iFrostizz
pushed a commit
to iFrostizz/foundry
that referenced
this pull request
Nov 9, 2022
…o `forge script` (foundry-rs#2524) * Add skip-simulation flag to bypass on-chain simulation * Add gas-estimate-multiplier cli argument * chore: nits Co-authored-by: Oliver Nordbjerg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In some edge cases the on-chain simulation currently blocks users from running certain types of transactions, even though they would work fine when submitted on chain.
See #2522
For cases like these it'd be great if the user could bypass on-chain simulation.
Solution
Add command line parameter
--skip-simulationthat the user can set to disable on chain simulation.When skipping simulation the gas costs will be estimated through the rpc-provider individually before each transaction submission.
When testing that new functionality the transactions ran out of gas and failed so I added the parameter
--gas-estimate-multiplierto manually adjust the factor by which gas estimates are inflated (or reduced).Default value for this is
130(meaning gas estimates will be multiplied by 1.3) which was the value previously hardcoded for estimations coming from the on-chain simulation.For consistency this default will also be applied to the provider estimate in the case the respective chain has a different gas calculation, which was previously used as returned by the provider (see this change), this should be the only change to the existing behaviour (when the user uses none of the new arguments).