Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update title page to reflect messaging guidelines #746

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

kprosise
Copy link
Contributor

@kprosise kprosise commented Sep 3, 2024

Changes to intro/product summary blurb made to follow Marketing messaging guidelines. Link at top no goes to product page of the foundries.io website.

Note that other requested changes which involve the sidebar, header, or footer will be handled in a separate PR.

QA: Ran linkcheck and viewed built HTML.

This commit addresses FFTK-3449

PR Template and Checklist

Please complete as much as possible to speed up the reviewing process.

Readiness and adding reviewers as appropriate is required.

All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.

Readiness

  • Merge (pending reviews)
  • Merge after date or event
  • Draft

Overview

Why merge this PR? What does it solve?

Checklist

  • Run spelling and grammar check, preferably with linter.
  • Avoid changing any header associated with a link/reference.
  • Step through instructions (or ask someone to do so).
  • Review for wordiness
  • Match tone and style of page/section.
  • Run make linkcheck.
  • View HTML in a browser to check rendering.
  • Use semantic newlines.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

Comments

Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.

Changes to intro/product summary blurb made to follow Marketing
messaging guidelines. Link at top no goes to product page of the
foundries.io website.

Note that other requested changes which involve the sidebar,
header, or footer will be handled in a separate PR.

QA: Ran linkcheck and viewed built HTML.

This commit addresses FFTK-3449

Signed-off-by: Katrina Prosise <[email protected]>
@kprosise kprosise requested review from vanmaegima and a team September 3, 2024 15:46
@doanac
Copy link
Member

doanac commented Sep 3, 2024

@kprosise kprosise merged commit 80f68bc into foundriesio:main Sep 4, 2024
2 of 3 checks passed
@kprosise kprosise deleted the update-title-page branch September 4, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants