Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise minimum PHP version to 7.4 #1425

Merged
merged 8 commits into from
Apr 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,9 @@ jobs:
- '8.1'
- '8.0'
- '7.4'
- '7.3'
- '7.2'
include:
- php: '7.4'
phpstan: true
- php: '7.2'
cs_fixer: true
check_client: true
- php: '8.2'
Expand Down
7 changes: 6 additions & 1 deletion .php-cs-fixer.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,14 @@
'@Symfony' => true,
// why would anyone put braces on different line
'braces' => ['position_after_functions_and_oop_constructs' => 'same'],
'function_declaration' => ['closure_function_spacing' => 'none'],
'function_declaration' => [
'closure_function_spacing' => 'none',
'closure_fn_spacing' => 'none',
],
// overwrite some Symfony rules
'concat_space' => ['spacing' => 'one'],
'global_namespace_import' => false,
'blank_line_between_import_groups' => false,
'phpdoc_align' => false,
'phpdoc_no_empty_return' => false,
'phpdoc_summary' => false,
Expand Down
3 changes: 2 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# selfoss news
## 2.20 – unreleased

**This version currently requires PHP 7.2.5 or newer. (Will be increased later.)**
**This version currently requires PHP 7.4 or newer. (Might be increased later.)**

### New features
- YouTube spout now accepts handles (starting with `@` sign). ([#1412](https://github.com/fossar/selfoss/pull/1412))
Expand All @@ -24,6 +24,7 @@
- Custom spout parameter declarations should now use constants from `Parameter` interface. ([#1409](https://github.com/fossar/selfoss/pull/1409))
- Custom spouts are expected to pass `HtmlString` object to items’ title and content. ([#1368](https://github.com/fossar/selfoss/pull/1368))
- Spouts can fetch item contents lazily by passing a function as `content` to `Item`. ([#1413](https://github.com/fossar/selfoss/pull/1413))
- Spouts’ `name`, `description` and `params` properties now require a type hint. ([#1425](https://github.com/fossar/selfoss/pull/1425))

### Other changes
- `tidy` PHP extension is now required if you want to use “Content extractor” spout. ([#1392](https://github.com/fossar/selfoss/pull/1392))
Expand Down
4 changes: 2 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"description": "Multipurpose rss reader, live stream, mashup, aggregation web application",
"type": "project",
"require": {
"php": ">= 7.2.5",
"php": ">= 7.4.0",
"ext-gd": "*",
"bcosca/fatfree-core": "^3.8",
"bramus/router": "^1.6",
Expand Down Expand Up @@ -52,7 +52,7 @@
},
"config": {
"platform": {
"php": "7.2.5"
"php": "7.4.0"
},
"allow-plugins": false,
"sort-packages": true
Expand Down
Loading