Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise minimum PHP version to 7.4 #1425

Merged
merged 8 commits into from
Apr 3, 2023
Merged

Raise minimum PHP version to 7.4 #1425

merged 8 commits into from
Apr 3, 2023

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Apr 3, 2023

  • docs: Fix minimum PHP version
  • composer: Update dependencies
  • Fix function argument alignment
  • Raise minimum PHP version to 7.4
  • Use flexible heredoc syntax
  • Switch to short closure syntax where appropriate
  • Add property type hints
  • Configuration: Add property type hints

@jtojnar
docs: Fix minimum PHP version
40cf650 
This was accidentally raised in 2.19:
d6e9bc8
@jtojnar
composer: Update dependencies
834a738
@jtojnar
Fix function argument alignment
0898189 
This will be enforced once we upgrade php-cs-fixer
@jtojnar
Raise minimum PHP version to 7.4
97157ad 
This will allow us to use typed properties, arrow functions,
having json_decode throw an exception, and flexible heredoc syntax.

https://www.php.net/releases/7_4_0.php
https://www.php.net/releases/7_3_0.php

And while Debian 10 Buster supports PHP 7.3 until June 2024,
continuing to support it is just too painful.
https://www.debian.org/releases/
https://wiki.debian.org/PHP
@jtojnar
Use flexible heredoc syntax
83bc832 
Also switch to HTML/XML as delimiter so that editors can apply correct syntax highlighting.
@jtojnar
Switch to short closure syntax where appropriate
bd321cb
@jtojnar
Add property type hints
2e2d838
@jtojnar
Configuration: Add property type hints
107c1b8
@netlify
Copy link

netlify bot commented Apr 3, 2023 •
edited
Loading

✅ Deploy Preview for selfoss ready!

Name Link
🔨 Latest commit 107c1b8
🔍 Latest deploy log https://app.netlify.com/sites/selfoss/deploys/642a743e8268630008126b31
😎 Deploy Preview https://deploy-preview-1425--selfoss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jtojnar jtojnar added this to the 2.20 milestone Apr 3, 2023
@jtojnar jtojnar merged commit 107c1b8 into master Apr 3, 2023
@jtojnar jtojnar deleted the php-7.4 branch April 3, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.20
Development

Successfully merging this pull request may close these issues.
1 participant
@jtojnar