-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
php84: init at 8.4.0beta3 #355
Conversation
9f536c8
to
b4a6f84
Compare
@jtojnar I have some libxml fixes here piotrkwiecinski/php-src-nix#1 unfortunately for older builds we have to apply additional patches. |
2763fd5
to
867b8b5
Compare
I bisected the mysqlnd issue to libxml2 bump which does not make sense to me. |
|
`v >= min && v < max` reads more naturally than `v < max && v >= min`
This is three major versions behind, it makes little sense to consider it the same project as the current redis. For example, Nixpkgs is going to apply patch for PHP 8.4.
f583faf
to
a56e422
Compare
Would it be hard to fix the failing darwin builds? |
Same as the previous commit, redis has sufficiently diverged from this version.
phpredis 6.1 will not support PHP < 7.4. In fact, one of the patches we apply to make it build with PHP 8.4 already broke PHP 7.0. Let’s just stay with a latest known working version for the older versions of PHP.
dbfacdc
to
57486a9
Compare
Those are failing dom tests. I can’t be bothered trying to debug them, just going to do |
0aa853e
to
9166b82
Compare
Many tests are failing there for some reason, someone should probably look into it.
Flake lock file updates: • Updated input 'nixpkgs': 'github:NixOS/nixpkgs/1e3deb3d8a86a870d925760db1a5adecc64d329d' (2024-06-27) → 'github:NixOS/nixpkgs/79ed718bf5fa685c44ed4607c314527ff832e53f' (2024-08-26) Upgrades libxml2 to 2.13, which includes some breaking changes. Since fixing them in older PHP versions would require extensive patching, let’s just pin the EOL PHP versions to a vendored libxml2 2.12. And because we just use it for PHP, we pare the libxml2 package down a bit (e.g. no Python or static support).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you want me to say here, I'm mind blown by what you did! Thank you!!!
mysqli socket regression test (
outputs.checks.x86_64-linux.php81-mysqli-socket-path
) fails, reportedly due to missing symbols:git log -p 1e3deb3d8a86a870d925760db1a5adecc64d329d...5de1564aed415bf9d0f281461babc2d101dd49ff -- '**php**'
mysqlnd.so
from known good Nixpkgs version using diffoscope but thecompress
symbol appears to be present in bothxdebug does not build with PHP 8.4 – we will need to switch to 3.4.0alpha1
redis does not build with PHP 8.4 php84.extensions.redis: Fix build NixOS/nixpkgs#336912
libxml2 patch needs backport php81: libxml 2.13 compatibility NixOS/nixpkgs#334411Decided to just vendor an older version of libxml2 since backporting the patche to an older PHP version would be too much work and breaks other stuff: