Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php84.extensions.redis: Fix build #336912

Merged
merged 1 commit into from
Aug 24, 2024
Merged

php84.extensions.redis: Fix build #336912

merged 1 commit into from
Aug 24, 2024

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Aug 24, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from piotrkwiecinski August 24, 2024 02:29
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Aug 24, 2024
@piotrkwiecinski
Copy link
Contributor

Result of nixpkgs-review pr 336912 run on x86_64-linux 1

4 packages built:
  • php81Extensions.redis
  • php82Extensions.redis
  • php83Extensions.redis
  • php84Extensions.redis

@drupol drupol merged commit ab8ea6a into NixOS:master Aug 24, 2024
24 checks passed
@jtojnar jtojnar deleted the php84-fixes branch August 24, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: php 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants