Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Reading slack token from env flag #22

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Conversation

ani1311
Copy link
Collaborator

@ani1311 ani1311 commented Oct 27, 2023

closes #21

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Files Coverage Δ
main.go 0.00% <0.00%> (ø)

📢 Thoughts on this report? Let us know!.

Copy link
Member

@ldemailly ldemailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@ldemailly
Copy link
Member

so that's 0.3.0 (incompatible (yet necessary) change)

@ani1311 ani1311 merged commit b403eb5 into main Oct 28, 2023
5 of 6 checks passed
@ani1311 ani1311 deleted the slack-token-env branch October 28, 2023 21:47
@ldemailly
Copy link
Member

@ani1311 Aniket, you should be able to make a release, right ? (and autogenerate release notes, then the github action will add the binary build and push the docker images)

@ani1311
Copy link
Collaborator Author

ani1311 commented Oct 29, 2023

Ya, I can do the release. Making 0.3.0 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Use Env var to get Slack API Tokens
2 participants