Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Use Env var to get Slack API Tokens #21

Closed
ani1311 opened this issue Oct 27, 2023 · 0 comments · Fixed by #22
Closed

Feature: Use Env var to get Slack API Tokens #21

ani1311 opened this issue Oct 27, 2023 · 0 comments · Fixed by #22

Comments

@ani1311
Copy link
Collaborator

ani1311 commented Oct 27, 2023

We should get API token as env var because kubernetes secrets are passed as env vars which is safer than using command line args.

Another addition to this could be that env var should be a comma seperated list of tokens. This list will then be used by the stateful sets mentioned here: #20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature: Reading slack token from env flag fortio/slack-proxy
1 participant
@ani1311