Move self test logic to a separate crate #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jethrogb
reviewed
Apr 12, 2023
jethrogb
reviewed
Apr 12, 2023
jethrogb
reviewed
Apr 12, 2023
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 12, 2023
244: Move self test logic to a separate crate r=jethrogb a=Taowyoo This PR is for fixing the link error: multiple define of `mbedtls_printf` when have different versions of `mbedtls` in dependency tree. According to `@jethrogb` 's idea: > I am proposing to create a new crate mbedtls-selftest which in Cargo.toml specifies links = mbedtls-selftest-support. It basically contains only the self_test module and the build script. All versions of MbedTLS would be updated to depend on a single version of mbedtls-selftest-support. The problem could be fixed by - moving `selftest` related implementation in `mbedtls` into a separate crate, here I named it: `mbedtls-selftest` (Done by this PR) - back-port this PR to old versions: such as `0.7.2` `0.8.1` Co-authored-by: Yuxiang Cao <[email protected]> Co-authored-by: YX Citrus <[email protected]>
|
I will create back-port PRs if this PR successfully merged, after back-port, new versions also need to be published
|
|
bors r- |
|
Canceled. |
jethrogb
reviewed
Apr 12, 2023
jethrogb
reviewed
Apr 12, 2023
jethrogb
reviewed
Apr 12, 2023
- Update `mbedtls-selftest`'s dependency of `mbedtls-sys-auto` to sync with `mbedtls` - Cleanup `mbedtls`'s feature requirements on `mbedtls-sys-auto`
This comment was marked as resolved.
This comment was marked as resolved.
|
bors r+ |
|
Build succeeded:
|
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for fixing the link error: multiple define of
mbedtls_printfwhen have different versions ofmbedtlsin dependency tree.According to @jethrogb 's idea:
The problem could be fixed by
selftestrelated implementation inmbedtlsinto a separate crate, here I named it:mbedtls-selftest(Done by this PR)0.7.20.8.1