Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve version management & avoid conflict between multiple version #246

Closed
11 tasks done
Taowyoo opened this issue Apr 13, 2023 · 4 comments · Fixed by #250, #251, #259, #260 or #254
Closed
11 tasks done

Improve version management & avoid conflict between multiple version #246

Taowyoo opened this issue Apr 13, 2023 · 4 comments · Fixed by #250, #251, #259, #260 or #254
Labels
dependencies Pull requests that update a dependency file enhancement

Comments

@Taowyoo
Copy link
Collaborator

Taowyoo commented Apr 13, 2023

Purpose

To make it's possible to have multiple versions of rust-mbedtls in the dependency tree.

The following works need to be done:

Able to compile together:

Better version management:

@Taowyoo
Copy link
Collaborator Author

Taowyoo commented Apr 21, 2023

Just realize that there also a lot of rust functions and function pointers are exposed in lib.rs and threading.rs.
They will also cause conflict, those functions could be solved by following same path of self test but the function pointers might be difficult to deal with.

@jethrogb
Copy link
Member

Yeah I guess we could make another crate mbedtls-platform-support. Especially for lib.rs I'm not sure if that will work properly for 0.7, because the features & conditional build logic supporting this changed pretty significantly in 0.8. I don't think the function pointers are a big deal, should work the same way?

@jethrogb
Copy link
Member

I'm not sure if that will work properly for 0.7

If it won't, then I think we should give up on this for now, possibly revert the mbedtls-selftest changes as well, and just do a flag day migration across all our projects.

@Taowyoo
Copy link
Collaborator Author

Taowyoo commented Apr 21, 2023

Got it, let me try if it's possible to split the code in 0.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment