Fix Websocket Lag #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe everything should be required to reply ? A simple OK or NO for success/fail. Then we can avoid special casing in the .js UPDATE: seems to work well |
|
I've no strong preference either way. If responding to all request you would also need to send a response for T0. |
|
Just got back in town. I'll take a look at these tomorrow after work and get familiar with them, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#78 introduced an issue where ws requests that don't cause a response to be sent, notably requests related to testing modes, caused the queue to wait for a 2000ms timeout on a response that wasn't coming.
Updated the queue so those requests that don't expect a response just pause the queue for 40ms. This removes the lag and also stops the possibility of test messages being sent faster than they could be responded to - e.g. when swiping around the colour picker. The queue just maintains the latest message of each type so if multiple colour requests are generated in that 40ms it is just the latest one that gets sent when the timer expires.