Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Websocket Queue #78

Merged
merged 5 commits into from
Nov 10, 2017
Merged

Add Websocket Queue #78

merged 5 commits into from
Nov 10, 2017

Conversation

cinoan
Copy link
Contributor

@cinoan cinoan commented Nov 10, 2017

Queue websocket requests from the client to avoid an issue with the server not receiving/responding to all requests if sent together. Fixes #65

@forkineye
Copy link
Owner

Thank you! This was the only thing holding up 3.0 and I've just been so busy lately that I haven't had time to work on the code. I'm out of town, but will merge and test next week. Thanks again!

@forkineye forkineye merged commit e412170 into forkineye:master Nov 10, 2017
@cinoan cinoan deleted the queueWS branch November 10, 2017 15:24
@cinoan
Copy link
Contributor Author

cinoan commented Nov 10, 2017

Definitely needs a good test but seems ok here and the interface works well on my Galaxy S8 now which always hit the issue before.

@penfold42
Copy link
Contributor

It seems to be really laggy on the static test.

In the past you could set the colour in real time but now it’s laggy. Even a single click on a colour might take a second to show up on the leds

@cinoan
Copy link
Contributor Author

cinoan commented Nov 12, 2017

Yes I saw the issue yesterday and wondered if it was in this version or was remnants from another commit I reverted, The issue is that when a request is sent it waits for a reply before sending the next message, or times out after 2 seconds. As the test mode requests don't get a response the get caught in this delay. I'll work on a fix now.

@cinoan cinoan mentioned this pull request Nov 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants