Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use compilation target instead of build machine target for MSRV checks #825

Merged
merged 3 commits into from
Nov 12, 2023

Conversation

foresterre
Copy link
Owner

@foresterre foresterre commented Nov 11, 2023

Instead of installing target toolchain directly, add the target toolchain as a target to the build machine toolchain.

The first commit does not attempt to address the same issue for the check, it only refactors the way toolchains and targets are installed. Next up will be ensuring that the target is included (at least by default) with cargo check --target <target>

closes #824
closes #587

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Attention: 156 lines in your changes are missing coverage. Please review.

Comparison is base (06864c7) 75.73% compared to head (d2e571f) 75.22%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #825      +/-   ##
==========================================
- Coverage   75.73%   75.22%   -0.51%     
==========================================
  Files          81       81              
  Lines        6057     6118      +61     
==========================================
+ Hits         4587     4602      +15     
- Misses       1470     1516      +46     
Files Coverage Δ
src/sub_command/find.rs 87.89% <100.00%> (ø)
src/sub_command/find/tests.rs 100.00% <100.00%> (ø)
src/cli/custom_check_opts.rs 50.00% <0.00%> (+50.00%) ⬆️
src/context/find.rs 14.81% <80.00%> (+14.81%) ⬆️
src/lib.rs 0.00% <0.00%> (ø)
src/command.rs 0.00% <0.00%> (ø)
src/context.rs 17.58% <0.00%> (-1.14%) ⬇️
src/context/verify.rs 0.00% <0.00%> (ø)
src/download.rs 0.00% <0.00%> (ø)
src/check/rustup_toolchain_check.rs 8.07% <12.50%> (+8.07%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Instead of installing target toolchain directly, add the target toolchain as a target to the build machine toolchain.

This commit does not attempt to address the same issue for the check, it only refactors the way toolchains and targets are installed.
If no target is specified, the target of the build machine is used instead.

Custom commands are not corrected, and need to supply their target themselves.
@foresterre foresterre marked this pull request as ready for review November 12, 2023 00:48
@foresterre foresterre changed the title refactor: Install build machine toolchain and add target refactor: Add target to build machine toolchain and use for checks Nov 12, 2023
…d machine target for MSRV checks to changelog
@foresterre foresterre changed the title refactor: Add target to build machine toolchain and use for checks refactor: Use compilation target instead of build machine target for MSRV checks Nov 12, 2023
@foresterre foresterre merged commit 968e5e3 into main Nov 12, 2023
18 checks passed
@foresterre foresterre deleted the split-install-target branch November 12, 2023 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant