Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use compilation target instead of build machine target for MSRV checks #824

Closed
foresterre opened this issue Nov 11, 2023 · 0 comments · Fixed by #825
Closed

Use compilation target instead of build machine target for MSRV checks #824

foresterre opened this issue Nov 11, 2023 · 0 comments · Fixed by #825
Assignees
Labels
Milestone

Comments

@foresterre
Copy link
Owner

foresterre commented Nov 11, 2023

I looked through the code and came to the conclusion that this crate seems to have an incorrect understanding of the way toolchains work.

  • 1.63.0-thumbv7em-none-eabihf means that our build machine is a thumbv7em-none-eabihf. This is most likely always constant; a machine doesn't spontaneously change its type.
  • The toolchain then has one or multiple installed targets. This is the compilation target machine, which is what the --target flag should actually control.

The current behavior, if being on an x86_64-unknown-linux-gnu machine and a --target thumbv7em-none-eabihf is specified and we want version 1.63.0, is:

  • rustup install 1.63.0-thumbv7em-none-eabihf --profile minimal

What should happen instead is:

  • rustup install 1.63.0 --profile minimal
  • rustup target add --toolchain 1.63.0 thumbv7em-none-eabihf

Sadly, this makes this crate completely unusable for cross compilation crates (like many embedded crates).

Originally posted by @Finomnis in #587 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant