-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report a CargoWorkspace event #1030
Merged
Merged
Commits on Oct 18, 2024
-
Report the CargoWorkspace event
The event contains the names (NB: not the package id's) of packages which were detected in the current cargo workspace. Possibly must be sent optionally in the future, because we should also support non cargo workspaces.
Configuration menu - View commit details
-
Copy full SHA for 7c100e7 - Browse repository at this point
Copy the full SHA 7c100e7View commit details
Commits on Oct 19, 2024
-
Only use the selection of workspace packages if cargo metadata succeeded
This works around some issues like: - cargo metadata only works for cargo projects, which is fine for most of our defaults, but we only hard require rustup right now for compatibility check commands like find and verify - an unwrap panic from within cargo metadata if it was given an invalid path Yet, the current choice is a pragmatic one and may not account for all cases or handle all errors.
Configuration menu - View commit details
-
Copy full SHA for 9cd8bc6 - Browse repository at this point
Copy the full SHA 9cd8bc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 86fd24f - Browse repository at this point
Copy the full SHA 86fd24fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9340b0a - Browse repository at this point
Copy the full SHA 9340b0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ca6a38a - Browse repository at this point
Copy the full SHA ca6a38aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 83009bf - Browse repository at this point
Copy the full SHA 83009bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 13ee5fd - Browse repository at this point
Copy the full SHA 13ee5fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for ac2ce77 - Browse repository at this point
Copy the full SHA ac2ce77View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.