Report a CargoWorkspace event #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The event contains the names (NB: not the package id's) of packages which were detected in the current cargo workspace. Possibly must be sent optionally in the future, because we should also support non cargo workspaces.
foresterre
force-pushed
the
event_detected_cargo_workspace_packages
branch
from
4232eee
to
7c100e7
Compare
This works around some issues like: - cargo metadata only works for cargo projects, which is fine for most of our defaults, but we only hard require rustup right now for compatibility check commands like find and verify - an unwrap panic from within cargo metadata if it was given an invalid path Yet, the current choice is a pragmatic one and may not account for all cases or handle all errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The event contains the names (NB: not the package id's) of packages which were detected in the current cargo workspace.
Possibly must be sent optionally in the future, because we should also support non cargo workspaces.
Nothing quite happens with this event yet, except if you use
--output-format json(then it will be serialized and logged).ref #1023
ref #1026