-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: match and update maxRevision entries with decoded keys #458
Conversation
refactor: pr feedback
QA notes: using linked SDR into STL, then SDR and STL linked in PDR (because Steve used plugin-source) deploy original use caseadd the title field to the Broker 1.1 layout and save
for reference, without these PRs, the result is still wrong but in a different way
✅ 🏆 retrieve updates the existing file. lets try to break itcreate new layout for Broker__c named
modify layout add a new, empty default pkgDir named Profiles also use encodingcreate
remove profile from forceignore
preview
create "path": "src/unpackaged3" and make it the default pkgDir. |
using latest SDR linked into STL, then STL linked into PDR. add Title field to v1.1 Broker Layout
|
QA: org create add Title field to v1.1 Broker Layout make a local and remote change to create a Conflict ✅✅✅✅✅✅ works with retrieving conflicts, too. |
QA: Profiles create |
What does this PR do?
Allows entries in maxRevision.json to be matched and updated by comparing decoded keys. For example, an entry in maxRevision.json with a key of
Layout__Broker__c-v1.1 Broker Layout
will match ongetSourceMember('Layout__Broker__c-v1%2E1 Broker Layout')
. It will also update the existing entry whensetMemberRevision('Layout__Broker__c-v1%2E1 Broker Layout', {...changes})
is called.Also, the
populateFilePaths
function will match remote changes with local metadata files using decoded metadata fullNames.This allows (e.g.)
sf project retrieve preview
to report the correct status, andsf project retrieve start
(i.e. "a pull") to update local metadata files correctly.What issues does this PR fix or reference?
@W-11658886@
forcedotcom/cli#1683
NOTE: for testing, SDR PR 1070 is required as well.