fix: match using decoded component keys in ComponentSet.has() #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
approved these changes
Aug 10, 2023
mshanemc
approved these changes
Aug 10, 2023
mshanemc
approved these changes
Aug 10, 2023
mshanemc
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows
ComponentSet.has()to match an entry with an encoded component key by first decoding it. For example, if a component set has a layout with a fullName ofAssignmentHistory__c-v1.34 Assignment History Layoutand we ask that component set if it has an entry with a fullName ofAssignmentHistory__c-v1%2E34 Assignment History Layout, it will now returntrue.What issues does this PR fix or reference?
@W-11658886@
forcedotcom/cli#1683
Functionality Before
Remote changed layouts with encoded API names would not match existing local layouts, and would be written to the default directory as a new file.
Functionality After
Remote changed layouts with encoded API names now can match existing local layouts, resulting in the layout content being updated in the correct file.