fix: only scan pkgDirs when merging non-decomposed MD #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristiand391
commented
Jul 14, 2022
| } else { | ||
| // defaultDirectory isn't a package, assumes it's the target output dir for conversion | ||
| // so no need to scan this folder | ||
| allNonDecomposed = []; |
There was a problem hiding this comment.
This is the output dir passed to the converter in the conversion pipeline, if the dir isn't a package in a project SDR don't need to scan it.
When running sfdx force:mdapi:convert -r mdapi -d src SDR will not look for non-decomposed metadata in /home/user/dreamhouse-lwc/src.
WillieRuemmele
approved these changes
Jul 19, 2022
QA Notes✅ : issue repository/steps now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates
NonDecompositionFinalizerto only scan the package directories in a DX project when merging non-decomposed metadata.If the
defaultDirectorypassed tofinalizeisn't a package dir it will ignore it.See: https://developer.salesforce.com/docs/atlas.en-us.sfdx_dev.meta/sfdx_dev/sfdx_dev_ws_mpd.htm
What issues does this PR fix or reference?
forcedotcom/cli#1540
@W-11186731@
Functionality Before
NonDecompositionFinalizerscans components in root project dir which causes issues when components are found in other folders (mdapi, etc).Functionality After
NonDecompositionFinalizerwill only scan components found inside of package directories, if the finalizer gets a defaultDirectory that's not a package it will threat it as the target output dir for a transformation and not scan it.