Skip to content

Commit

Permalink
Pr/645 (#664)
Browse files Browse the repository at this point in the history
* fix: support jsforce 2.0

* chore: auto-update metadata coverage in METADATA_SUPPORT.md

Co-authored-by: jayree <[email protected]>
  • Loading branch information
shetzel and jayree authored Jul 12, 2022
1 parent 72c8d03 commit 3af34ce
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
5 changes: 4 additions & 1 deletion METADATA_SUPPORT.md
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,7 @@ v56 introduces the following new types. Here's their current level of support

|Metadata Type|Support|Notes|
|:---|:---|:---|
|AIUsecaseDefinition||Not supported, but support could be added (but not for tracking)|
|AIUsecaseDefinition|⚠️|Supports deploy/retrieve but not source tracking|
|AccountingFieldMapping||Not supported, but support could be added|
|AccountingSettings|||
|BotBlock||Not supported, but support could be added|
Expand All @@ -521,6 +521,9 @@ v56 introduces the following new types. Here's their current level of support
|DataSourceBundleDefinition|||
|DataSrcDataModelFieldMap|||
|DataStreamTemplate|||
|DigitalExperience||Not supported, but support could be added (but not for tracking)|
|DigitalExperienceBundle||Not supported, but support could be added (but not for tracking)|
|DigitalExperienceConfig||Not supported, but support could be added (but not for tracking)|
|ExplainabilityMsgActionDefinition||Not supported, but support could be added|
|ExpressionSetObjectAlias||Not supported, but support could be added|
|FuelType||Not supported, but support could be added|
Expand Down
2 changes: 1 addition & 1 deletion src/resolve/connectionResolver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export class ConnectionResolver {
for await (const componentResult of componentPromises) {
for (const component of componentResult) {
let componentType: MetadataType;
if (typeof component.type === 'string') {
if (typeof component.type === 'string' && component.type.length) {
componentType = this.registry.getTypeByName(component.type);
} else {
// fix { type: { "$": { "xsi:nil": "true" } } }
Expand Down

0 comments on commit 3af34ce

Please sign in to comment.