Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw an error for unexpected child types #426

Merged
merged 4 commits into from
Aug 18, 2021

Conversation

shetzel
Copy link
Contributor

@shetzel shetzel commented Aug 17, 2021

What does this PR do?

When resolving source and an unexpected child type (e.g., ApexClass) is found within a strictFolderType (e.g., CustomObject) an error will be thrown.

What issues does this PR fix or reference?

github issue: forcedotcom/cli#1106
@W-9764876@

Functionality Before

TypeError: Cannot set property 'content' of undefined
at DecomposedSourceAdapter.populate (source-deploy-retrieve/lib/src/resolve/adapters/decomposedSourceAdapter.js:77:35)

Functionality After

Better error with more information about the cause of the problem. E.g.,

Unexpected child metadata [/path/to/project/force-app/main/default/objects/Case/layouts/Case-Case Layout.layout-meta.xml] found for parent type [CustomObject] 

@shetzel shetzel requested review from a team as code owners August 17, 2021 16:22
Copy link
Member

@WillieRuemmele WillieRuemmele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with a project like objects/<my object>/classes/myclass.cls it would throw the error when

  • convert
  • deploy
  • retrieve

tested with layouts, classes, pages under custom objects, and under other metadata types

@WillieRuemmele WillieRuemmele merged commit c40cd97 into develop Aug 18, 2021
@WillieRuemmele WillieRuemmele deleted the sh/fix-content-of-undefined branch August 18, 2021 19:56
AnanyaJha pushed a commit that referenced this pull request Aug 19, 2021
* fix: throw an error for unexpected child types

* fix: throw better error when transforming invalid child

* fix: ensure valid children during retrieve

Co-authored-by: Willie Ruemmele <[email protected]>
shetzel added a commit that referenced this pull request Aug 20, 2021
* fix: export all public TS types and interfaces (#423)

* fix: making exports in the right format

@W-9727845@

* chore: removing yarn changes

* fix: xml nodes might not be arrays (#424)

Co-authored-by: Willie Ruemmele <[email protected]>

* fix: throw an error for unexpected child types (#426)

* fix: throw an error for unexpected child types

* fix: throw better error when transforming invalid child

* fix: ensure valid children during retrieve

Co-authored-by: Willie Ruemmele <[email protected]>

* fix: force fullName to CustomLabels (#427)

* fix: force fullName to CustomLabels

* chore: update prop name

* fix: backward support for toolbelt suffix differences

* Revert "fix: backward support for toolbelt suffix differences"

This reverts commit 9cf9505.

Co-authored-by: mshanemc <[email protected]>
Co-authored-by: Willie Ruemmele <[email protected]>

* fix: forceIgnore does not work for `SFDX: Retrieve Source in Manifest from Org` in vscode extension (#413)

* fix: forceIgnore does not work with retrieve manifest

* fix: matchingContent subfolder

* Wr/content type of undefined (#429)

* chore: initial pass on preventing improperly structured static resources

* chore: added error message

Co-authored-by: Shane McLaughlin <[email protected]>

* fix: support toolbelt suffixes (#428)

* fix: force fullName to CustomLabels

* chore: update prop name

* fix: backward support for toolbelt suffix differences

* Revert "fix: backward support for toolbelt suffix differences"

This reverts commit 9cf9505.

* fix: support toolbelt suffixes

* feat: support legacy suffix conversion

Co-authored-by: Mike Donnalley <[email protected]>
Co-authored-by: Willie Ruemmele <[email protected]>

Co-authored-by: vamsimundra <[email protected]>
Co-authored-by: Shane McLaughlin <[email protected]>
Co-authored-by: Willie Ruemmele <[email protected]>
Co-authored-by: Steve Hetzel <[email protected]>
Co-authored-by: Mike Donnalley <[email protected]>
Co-authored-by: Violet Yao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants