fix: forceIgnore does not work for SFDX: Retrieve Source in Manifest from Org in vscode extension
#413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xyc
reviewed
Aug 5, 2021
jag-j
reviewed
Aug 17, 2021
…eploy-retrieve into violet/force-ignore
jag-j
approved these changes
Aug 18, 2021
AnanyaJha
pushed a commit
that referenced
this pull request
Aug 19, 2021
… from Org` in vscode extension (#413) * fix: forceIgnore does not work with retrieve manifest * fix: matchingContent subfolder
shetzel
added a commit
that referenced
this pull request
Aug 20, 2021
* fix: export all public TS types and interfaces (#423) * fix: making exports in the right format @W-9727845@ * chore: removing yarn changes * fix: xml nodes might not be arrays (#424) Co-authored-by: Willie Ruemmele <[email protected]> * fix: throw an error for unexpected child types (#426) * fix: throw an error for unexpected child types * fix: throw better error when transforming invalid child * fix: ensure valid children during retrieve Co-authored-by: Willie Ruemmele <[email protected]> * fix: force fullName to CustomLabels (#427) * fix: force fullName to CustomLabels * chore: update prop name * fix: backward support for toolbelt suffix differences * Revert "fix: backward support for toolbelt suffix differences" This reverts commit 9cf9505. Co-authored-by: mshanemc <[email protected]> Co-authored-by: Willie Ruemmele <[email protected]> * fix: forceIgnore does not work for `SFDX: Retrieve Source in Manifest from Org` in vscode extension (#413) * fix: forceIgnore does not work with retrieve manifest * fix: matchingContent subfolder * Wr/content type of undefined (#429) * chore: initial pass on preventing improperly structured static resources * chore: added error message Co-authored-by: Shane McLaughlin <[email protected]> * fix: support toolbelt suffixes (#428) * fix: force fullName to CustomLabels * chore: update prop name * fix: backward support for toolbelt suffix differences * Revert "fix: backward support for toolbelt suffix differences" This reverts commit 9cf9505. * fix: support toolbelt suffixes * feat: support legacy suffix conversion Co-authored-by: Mike Donnalley <[email protected]> Co-authored-by: Willie Ruemmele <[email protected]> Co-authored-by: vamsimundra <[email protected]> Co-authored-by: Shane McLaughlin <[email protected]> Co-authored-by: Willie Ruemmele <[email protected]> Co-authored-by: Steve Hetzel <[email protected]> Co-authored-by: Mike Donnalley <[email protected]> Co-authored-by: Violet Yao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
SFDX: Retrieve Source in Manifest from Orgcommand in vscode extension, 1) files in.forceIgnoreare not printed inchannelService(which is the expected behavior) 2) however, files in.forceIgnoreare still retrieved and they overwrite the local version (which is not the expected behavior).This PR fixes the issue where forceIgnore does not work for
SFDX: Retrieve Source in Manifest from Orgin vscode extension, by keeping track of a list of forceIgnoredPaths explored in resolver and skip those forceIgnoredPaths during writing.force-app/main/default/classes/ApexClassExample.cls, while their original paths areforce-app/main/default/classes/subfolder/ApexClassExample.cls.What issues does this PR fix or reference?
forcedotcom/salesforcedx-vscode#3236, @W-9293630@, @W-9682706@
Functionality Before
.forceIgnore did not work for retrieving a componentSet constructed from
ComponentSet.fromManifest.Functionality After
.forceIgnore works for retrieving a componentSet constructed from
ComponentSet.fromManifest.