Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #55: Check commit comment length #56

Merged
merged 3 commits into from
Apr 16, 2018
Merged

Fixes #55: Check commit comment length #56

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6317678
Fixes #55: Check commit comment length
Ichabond Nov 27, 2017
9ab98f0
Update error message for commit comment length error
Ichabond Nov 27, 2017
2661791
Truncate comment length to maximum of 60
Ichabond Apr 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pyIOSXR/iosxr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,14 +579,14 @@ def commit_config(self, label=None, comment=None, confirmed=None):
Commit the candidate config.

:param label: Commit comment, displayed in the commit entry on the device.
:param comment: Commit label, displayed instead of the commit ID on the device.
:param comment: Commit label, displayed instead of the commit ID on the device. (Max 60 characters)
:param confirmed: Commit with auto-rollback if new commit is not made in 30 to 300 sec
"""
rpc_command = '<Commit'
if label:
rpc_command += ' Label="%s"' % label
if comment:
rpc_command += ' Comment="%s"' % comment
rpc_command += ' Comment="%s"' % comment[:60]
if confirmed:
if 30 <= int(confirmed) <= 300:
rpc_command += ' Confirmed="%d"' % int(confirmed)
Expand Down