Fixes #55: Check commit comment length #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raise an InvalidInputError when the commit message is longer than 60 characters, as this breaks IOS-XR.
luke-orden
reviewed
Nov 27, 2017
pyIOSXR/iosxr.py
Outdated
| if len(comment) <= 60: | ||
| rpc_command += ' Comment="%s"' % comment | ||
| else: | ||
| raise InvalidInputError('comment needs to be shorter than 60 characters', self) |
There was a problem hiding this comment.
It can be up to and including 60 characters
Rephrase the commit comment error to better reflect the limits.
1 similar comment
|
Thanks to @loverend for the reworded message. |
mirceaulinic
requested changes
Jan 12, 2018
pyIOSXR/iosxr.py
Outdated
| if len(comment) <= 60: | ||
| rpc_command += ' Comment="%s"' % comment | ||
| else: | ||
| raise InvalidInputError('comment should be no more than 60 characters', self) |
There was a problem hiding this comment.
We should just trim the commit message when it's longer than 60 characters.
Instead of raising an exception, just truncate the comment length to the maximum of 60
mirceaulinic
approved these changes
Apr 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise an InvalidInputError when the commit message is longer than 60 characters, as this breaks IOS-XR.