[Dependency] Fix compatibility issue with less >= 3.5 due to math changes #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for calc Replaces all tilde string escaping with explicit function calls. This was tested with [email protected] and [email protected] Reported in Semantic-Org/Semantic-UI#6512
ColinFrick
added
type/bug
ColinFrick
changed the title
y0hami
approved these changes
Aug 20, 2018
prudho
reviewed
Aug 20, 2018
| @@ -1112,12 +1112,12 @@ | |||
| .ui.relaxed[class*="vertically divided"].grid > .row:before { | |||
| margin-left: (@relaxedGutterWidth / 2); | |||
| margin-right: (@relaxedGutterWidth / 2); | |||
| width: ~"calc(100% - "@relaxedGutterWidth~")"; | |||
| width: e(%("calc(100%% - %d)", @relaxedGutterWidth)); | |||
There was a problem hiding this comment.
100%% ? This might not be correct.
EDIT: (happen 18 times in the code)
There was a problem hiding this comment.
It is:
If you need to print the percentage symbol, escape it by another percentage %%.
prudho
approved these changes
Aug 20, 2018
Closed
|
This als fixes |
|
This is save for LESS 3.8 aswell and also fixes |
This was referenced Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces all tilde string escaping with explicit function calls.
This was tested with [email protected] and [email protected]
Reported in Semantic-Org/Semantic-UI#6512