Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUI] Merge 2.4.1 #173

Closed
ColinFrick opened this issue Oct 14, 2018 · 3 comments
Closed

[SUI] Merge 2.4.1 #173

ColinFrick opened this issue Oct 14, 2018 · 3 comments
Labels
lang/css Anything involving CSS lang/javascript Anything involving JavaScript type/bug Any issue which is a bug or PR which fixes a bug

Comments

@ColinFrick
Copy link
Member

Feature Request

Description

Merge Semantic UI 2.4.1 release

I propose only to merge following changes:

Will be fixed with #172:
Dropdown - clearable dropdown now works with dropdown that arent on:click, like hover or manual triggers.

Already fixed with #135:
Modal - Fixed fullscreen modal having incorrect left offset with flex modals

Build system update to gulp 4 is almost finished. Additionally we have less 3.5.0 support since #97

@ColinFrick ColinFrick added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS lang/javascript Anything involving JavaScript labels Oct 14, 2018
@lubber-de
Copy link
Member

Your fixes for modal and clearable are a bit different to Jack's ones from sui. Have you found out his fixes are still not working?

@ColinFrick
Copy link
Member Author

@lubber-de We have a different implementation for clearable dropdowns.
Additionally as our code base diverges more and more, we can't merge just anything from SUI anymore, even if Jack's fix works in SUI.

@y0hami
Copy link
Member

y0hami commented Oct 18, 2018

Merged.

@y0hami y0hami closed this as completed Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS lang/javascript Anything involving JavaScript type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

No branches or pull requests

3 participants