Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dimmer): support individual show/hide duration #1974

Conversation

lubber-de
Copy link
Member

Description

This PR adds the same syntax for the optional hideDuration/showDuration value of the transition setting to the dimmer module as we already have in toast, modal, popup and dropdown.

As dimmer was the only module which was already/also supporting an object for the duration value, i kept the logic in for backward compatibility

Testcase

https://jsfiddle.net/lubber/x2dzht4b/6/

@lubber-de lubber-de added type/feat Any feature requests or improvements lang/javascript Anything involving JavaScript state/awaiting-reviews Pull requests which are waiting for reviews labels May 30, 2021
@lubber-de lubber-de added this to the 2.8.8 milestone May 30, 2021
@lubber-de
Copy link
Member Author

Docs added by fomantic/Fomantic-UI-Docs#280

@lubber-de lubber-de added the state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo label May 30, 2021
Copy link
Contributor

@prudho prudho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lubber-de lubber-de changed the title feat(dimmer): support individual show/hide duration in transition setting feat(dimmer): support individual show/hide duration Jun 2, 2021
@lubber-de lubber-de merged commit 68bf29f into fomantic:develop Jun 2, 2021
@lubber-de lubber-de deleted the feat/uniqueTransitionSettingDimmerDuration branch June 2, 2021 16:34
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label Jun 2, 2021
lubber-de added a commit to fomantic/Fomantic-UI-Docs that referenced this pull request Jun 6, 2021
Added settings info for the new unique transition syntax for individual show/hide methods/duration in dimmer, modal, popup and dropdown as of
fomantic/Fomantic-UI#1867
fomantic/Fomantic-UI#1869
fomantic/Fomantic-UI#1966
fomantic/Fomantic-UI#1974
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/javascript Anything involving JavaScript state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo type/feat Any feature requests or improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants