-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dimmer): support individual show/hide transition #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/feat
Any feature requests or improvements
lang/javascript
Anything involving JavaScript
labels
Feb 6, 2021
lubber-de
added
state/awaiting-reviews
Pull requests which are waiting for reviews
state/awaiting-docs
Pull requests which need doc changes/additions
labels
Feb 6, 2021
ColinFrick
approved these changes
Feb 8, 2021
y0hami
approved these changes
Feb 19, 2021
lubber-de
removed
the
state/awaiting-reviews
Pull requests which are waiting for reviews
label
Feb 19, 2021
lubber-de
added
state/has-docs
A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo
and removed
state/awaiting-docs
Pull requests which need doc changes/additions
labels
Feb 20, 2021
Docs added by fomantic/Fomantic-UI-Docs#264 |
lubber-de
added a commit
that referenced
this pull request
Feb 25, 2021
This PR adds the possibility of using JS config templates for the modal module. That means you can declare a reusable dynamic template function which returns predefined config settings (modified depending of your input to the template function) as the modal is already prepared to create dynamic content out of pure js since #1774 For this reason modal now also has an optional autoshow option, which enables you to immediatly show the modal on instantiation time, so no more need for $(.ui.modal).modal({closable:false}).modal('show') but $(.ui.modal).modal({closable:false, autoShow:true}) Modal now also can use the transition methods for show/hide individually (backwards compatible) (just like in toast and for dimmer in #1867)
lubber-de
added a commit
to fomantic/Fomantic-UI-Docs
that referenced
this pull request
Feb 27, 2021
Optional individual show/hide methods as of fomantic/Fomantic-UI#1867
lubber-de
added a commit
to fomantic/Fomantic-UI-Docs
that referenced
this pull request
Jun 6, 2021
Added settings info for the new unique transition syntax for individual show/hide methods/duration in dimmer, modal, popup and dropdown as of fomantic/Fomantic-UI#1867 fomantic/Fomantic-UI#1869 fomantic/Fomantic-UI#1966 fomantic/Fomantic-UI#1974
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
lang/javascript
Anything involving JavaScript
state/has-docs
A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo
type/feat
Any feature requests or improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR offers the same possibility to provide individual transform methods for show and hide animations as we have for
toast
So in addition to
transition:'fade'
(which still works so stays backward compatible), you can now use the same as in toast: