Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dimmer): support individual show/hide transition #1867

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Feb 6, 2021

Description

This PR offers the same possibility to provide individual transform methods for show and hide animations as we have for toast

So in addition to transition:'fade' (which still works so stays backward compatible), you can now use the same as in toast:

transition: {
  showMethod: 'fade',
  hideMethod: 'zoom'
}

@lubber-de lubber-de added type/feat Any feature requests or improvements lang/javascript Anything involving JavaScript labels Feb 6, 2021
@lubber-de lubber-de added this to the 2.8.8 milestone Feb 6, 2021
@lubber-de lubber-de added state/awaiting-reviews Pull requests which are waiting for reviews state/awaiting-docs Pull requests which need doc changes/additions labels Feb 6, 2021
@lubber-de lubber-de merged commit 5992784 into fomantic:develop Feb 19, 2021
@lubber-de lubber-de deleted the feat/dimmertransition branch February 19, 2021 21:53
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label Feb 19, 2021
@lubber-de lubber-de added state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo and removed state/awaiting-docs Pull requests which need doc changes/additions labels Feb 20, 2021
@lubber-de
Copy link
Member Author

Docs added by fomantic/Fomantic-UI-Docs#264

lubber-de added a commit that referenced this pull request Feb 25, 2021
This PR adds the possibility of using JS config templates for the modal module.
That means you can declare a reusable dynamic template function which returns predefined config settings (modified depending of your input to the template function) as the modal is already prepared to create dynamic content out of pure js since #1774

For this reason modal now also has an optional autoshow option, which enables you to immediatly show the modal on instantiation time, so no more need for $(.ui.modal).modal({closable:false}).modal('show') but $(.ui.modal).modal({closable:false, autoShow:true})

Modal now also can use the transition methods for show/hide individually (backwards compatible) (just like in toast and for dimmer in #1867)
lubber-de added a commit to fomantic/Fomantic-UI-Docs that referenced this pull request Feb 27, 2021
lubber-de added a commit to fomantic/Fomantic-UI-Docs that referenced this pull request Jun 6, 2021
Added settings info for the new unique transition syntax for individual show/hide methods/duration in dimmer, modal, popup and dropdown as of
fomantic/Fomantic-UI#1867
fomantic/Fomantic-UI#1869
fomantic/Fomantic-UI#1966
fomantic/Fomantic-UI#1974
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/javascript Anything involving JavaScript state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo type/feat Any feature requests or improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants