STRWEB-110 ignore order of CSS imports #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `@folio/consortia-settings` to a platform build generates tens of thousands of lines of warnings form mini-css-extract-plugin about its inability to determine what order to assemble its CSS rules in because different files have the imports in a different order. It seems likely we don't have to worry about this since per-module CSS will be scoped to that module by postcss, and shared CSS will just be in stripes-components, but this could be riskier than I realize, and a better approach may be to try to figure out what is happening in `@folio/consortia-settings` that is different than every other module we've added to the platform so far. Refs STRWEB-110
JohnC-80
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
@folio/consortia-settingsto a platform build generates tens of thousands of lines of warnings form mini-css-extract-plugin about its inability to determine what order to assemble its CSS rules in because different files have the imports in a different order.It seems likely we don't have to worry about this since per-module CSS will be scoped to that module by postcss, and shared CSS will just be in stripes-components, but this could be riskier than I realize, and a better approach may be to try to figure out what is happening in
@folio/consortia-settingsthat is different than every other module we've added to the platform so far.Refs STRWEB-110