Skip to content

Commit

Permalink
STRWEB-110 ignore order of CSS imports (#141)
Browse files Browse the repository at this point in the history
Add `@folio/consortia-settings` to a platform build generates tens of
thousands of lines of warnings form mini-css-extract-plugin about its
inability to determine what order to assemble its CSS rules in because
different files have the imports in a different order.

It seems likely we don't have to worry about this since per-module CSS
will be scoped to that module by postcss, and shared CSS will just be in
stripes-components, but this could be riskier than I realize, and a
better approach may be to try to figure out what is happening in
`@folio/consortia-settings` that is different than every other module
we've added to the platform so far.

Refs STRWEB-110
  • Loading branch information
zburke authored Apr 1, 2024
1 parent 3a4f947 commit 93362cb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## 5.2.0 IN PROGRESS

* Don't worry about the order of CSS imports across modules. Refs STRWEB-110.

## [5.1.0](https://github.com/folio-org/stripes-webpack/tree/v5.1.0) (2024-03-12)
[Full Changelog](https://github.com/folio-org/stripes-webpack/compare/v5.0.0...v5.1.0)

Expand Down
2 changes: 1 addition & 1 deletion webpack.config.cli.prod.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ const buildConfig = (stripesConfig) => {
prodConfig.module.rules.push(esbuildLoaderRule(allModulePaths));

prodConfig.plugins.push(
new MiniCssExtractPlugin({ filename: 'style.[contenthash].css' })
new MiniCssExtractPlugin({ filename: 'style.[contenthash].css', ignoreOrder: true })
);

return prodConfig;
Expand Down

0 comments on commit 93362cb

Please sign in to comment.