STCLI-193 avoid sabotaged isBinaryFile #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A breaking change to node compatibilty for `isBinaryFile`, a transitive dependency via `karma`, was published in a patch release. It isn't clear if the author doesn't understand semantic versioning or just doesn't care about it, but multiple pleas to move the changes to a new major version and publish a patch to restore compatibility in the 4.0.x line were rebuffed (gjtorikian/isBinaryFile#51). Refs STCLI-193
|
Kudos, SonarCloud Quality Gate passed!
|
NikitaSedyx
approved these changes
Mar 25, 2022
JohnC-80
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A breaking change to node compatibilty for
isBinaryFile, a transitivedependency via
karma, was published in a patch release. It isn't clearif the author doesn't understand semantic versioning or just doesn't
care about it, but multiple pleas to move the changes to a new major
version and publish a patch to restore compatibility in the 4.0.x line
were rebuffed (gjtorikian/isBinaryFile#51).
Refs STCLI-193