Skip to content

Commit

Permalink
STCLI-193 avoid sabotaged isBinaryFile (#281)
Browse files Browse the repository at this point in the history
A breaking change to node compatibilty for `isBinaryFile`, a transitive
dependency via `karma`, was published in a patch release. It isn't clear
if the author doesn't understand semantic versioning or just doesn't
care about it, but multiple pleas to move the changes to a new major
version and publish a patch to restore compatibility in the 4.0.x line
were rebuffed (gjtorikian/isBinaryFile#51).

Refs STCLI-193
  • Loading branch information
zburke authored Mar 25, 2022
1 parent 2e1f684 commit 3aaf0ba
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Change history for stripes-cli

## 2.6.0 (IN PROGRESS)

* Avoid sabotaged `isBinaryFile`. Fixes STCLI-193.

## [2.5.0](https://github.com/folio-org/stripes-cli/tree/v2.5.0) (2022-02-08)

* Update webpack to v5. Refs STCLI-187.
Expand Down
3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -75,5 +75,8 @@
"eslint": "^7.32.0",
"sinon": "^4.1.4",
"sinon-chai": "^2.14.0"
},
"resolutions": {
"isbinaryfile": "4.0.8"
}
}

0 comments on commit 3aaf0ba

Please sign in to comment.