Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add routing for pagination in TYPO3 11 #250

Closed
Tracked by #249
fnagel opened this issue Dec 17, 2021 · 4 comments
Closed
Tracked by #249

Add routing for pagination in TYPO3 11 #250

fnagel opened this issue Dec 17, 2021 · 4 comments
Labels
bug help wanted typo3 11.x
Milestone
Version 7.0.0

Comments

@fnagel
Copy link
Owner

fnagel commented Dec 17, 2021 •
edited
Loading

I was not able to make pagination routing work.

When enable routing for pagination, the current page is no longer available in controller, not sure why... In addition, it breaks all other routes.

Any help appreciated!

See 09ba868
@fnagel fnagel mentioned this issue Dec 17, 2021
Closed
57 tasks
@fnagel fnagel changed the title Add routing for pagination Add routing for pagination in TYPO3 11 Dec 17, 2021
@fnagel fnagel added this to the Version 7.0.0 milestone Dec 17, 2021
fnagel added a commit that referenced this issue Dec 17, 2021
@fnagel
[TASK] Disable pagination routing
f5fe670 
Disable pagination routing for now as it breaks pagination.
Without routing everything works fine. See #250
@fnagel fnagel mentioned this issue Dec 23, 2021
Open
fnagel added a commit that referenced this issue Jan 29, 2022
@fnagel
[TASK] Disable pagination routing
09ba868 
Disable pagination routing for now as it breaks pagination.
Without routing everything works fine. See #250
@fnagel
Copy link
Owner Author

fnagel commented Mar 2, 2022

Looks like this is an issue due to page_localized aspect has the same default value "page" as the actual parameter. This might be the reason why EXT:news uses currentPage instead of page as parameter name.

If this really is the issue, we need to change the methods argument name and the routing config.

@fnagel
Copy link
Owner Author

fnagel commented Mar 14, 2022 •
edited
Loading

Changing the argument to currentPage does not help. Seems this is an issue with our page_localized prefix. Maybe a core bug.

@fnagel
Copy link
Owner Author

fnagel commented Mar 14, 2022

Seems it's not about page_localized but using "page" as a prefix (/page/{page-placeholder}). Which seems strange as this is even the case when all arguments (controller action argument, pagination partial, routing config) have been changed to currentPage. Only working solution would be using something like /page-{page-placeholder} which is different to what we had before.

Any help appreciated.

fnagel added a commit that referenced this issue Mar 19, 2022
@fnagel
[FIX] Change pagination routing
b049cdc 
Switching from /{post_page_localized}/{post_page} to /{post_page_localized}-{post_page}
will fix non working pagination routing in TYPO3 11. See issue #250 for more info.

Follow-up to 09ba868
Closes to #250
@fnagel
Copy link
Owner Author

fnagel commented Mar 19, 2022

Implemented a workaround by using /{post_page_localized}-{post_page} for pagination routing.

@fnagel fnagel closed this as completed Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted typo3 11.x
Projects
None yet
Milestone
Version 7.0.0
Development

No branches or pull requests
1 participant
@fnagel