Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging enhancement #32

Merged
merged 3 commits into from
Aug 8, 2021
Merged

logging enhancement #32

merged 3 commits into from
Aug 8, 2021

Conversation

yugeeklab
Copy link
Contributor

@yugeeklab yugeeklab commented Aug 2, 2021 •
edited
Loading

#2 logging enhancement.

I use pino.

frontend
pino

server
pino
pino-elasticsearch
pino-multi-stream
@elastic/ecs-pino-format

frontend

In Chrome Browser
image

server

In terminal
image

In Kibana
image

Let me know if you want more enhancement

fmeringdal
fmeringdal requested changes Aug 4, 2021
View reviewed changes
Copy link
Owner

@fmeringdal fmeringdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @YuTaeseong ,

Thanks for your PR. It looks good, but just needs a couple of changes before it can be approved :)

server/src/config/index.ts Outdated Show resolved Hide resolved
server/src/logger.ts Outdated Show resolved Hide resolved
@yugeeklab
Copy link
Contributor Author

yugeeklab commented Aug 5, 2021 •
edited
Loading

Hi @YuTaeseong ,

Thanks for your PR. It looks good, but just needs a couple of changes before it can be approved :)

@fmeringdal I've done your request!!

fmeringdal
fmeringdal approved these changes Aug 8, 2021
View reviewed changes
Copy link
Owner

@fmeringdal fmeringdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@fmeringdal fmeringdal merged commit e401dec into fmeringdal:main Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmeringdal fmeringdal fmeringdal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yugeeklab @fmeringdal